chore: run validation when debug assertion enabled and not only for test#9073
Merged
Jefffrey merged 1 commit intoapache:mainfrom Jan 1, 2026
Conversation
Jefffrey
approved these changes
Jan 1, 2026
Contributor
|
Thanks @rluvaton |
rluvaton
deleted the
run-assertion-when-debug-assertion-enabled-and-not-when-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
More coverage, I might not be compiling for tests and still want this validation
What changes are included in this PR?
replace test with debug assertion
Are these changes tested?
No
Are there any user-facing changes?
not API change